Track comment content edits separately from reaction updates#476
Merged
netchampfaris merged 6 commits intodevelopfrom Apr 22, 2026
Merged
Track comment content edits separately from reaction updates#476netchampfaris merged 6 commits intodevelopfrom
netchampfaris merged 6 commits intodevelopfrom
Conversation
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894 Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894 Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894 Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894 Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894 Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/cf2a5f48-b6e0-493b-b116-e29e7fd9152e Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
netchampfaris
April 22, 2026 07:06
View session
gameplan
|
||||||||||||||||||||||||||||||
| Project |
gameplan
|
| Branch Review |
copilot/fix-comment-edited-notification
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Copilot |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
7
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments were deriving their edited state from the document
modifiedtimestamp, so reaction changes surfaced asEdited. This change introduces an explicit content-edit timestamp forGP Commentand drives the UI from that field instead of generic document mutation time.Backend: explicit edit tracking
edited_attoGP Comment.edited_atonly whencontentchanges on an existing comment.UI: edited state reflects content changes only
Editedlabel to usecomment.edited_at.Revisionsvisibility to the same field, so revision affordances only appear after a real content edit.Data fetch/types
edited_atin comment list queries andGPCommenttypings so timeline consumers have the new source of truth.Migration
edited_atfromVersionrows where thecontentfield changed.gameplan/gameplan/doctype/gp_comment/patches/and updatedpatches.txtto the new module path.